Fix overrides generation for "naked" single case unions #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AbbreviationRepresentation Add the needed code to add a bar and fix their indentation
auduchinok
reviewed
May 24, 2023
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateProvider.fs
Outdated
Show resolved
Hide resolved
… IUnionRepresentation node. Use a Navigator.Set* method and mutate the context.Anchor if needed.
auduchinok
reviewed
May 26, 2023
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateProvider.fs
Outdated
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateProvider.fs
Outdated
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateProvider.fs
Outdated
Show resolved
Hide resolved
- remove cast to IUnionRepresentation - add test case for type U = ``A B``
auduchinok
reviewed
May 26, 2023
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateProvider.fs
Outdated
Show resolved
Hide resolved
…Provider.fs Co-authored-by: Eugene Auduchinok <[email protected]>
auduchinok
reviewed
May 26, 2023
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateProvider.fs
Outdated
Show resolved
Hide resolved
DedSec256
pushed a commit
that referenced
this pull request
Jun 6, 2023
Co-authored-by: Eugene Auduchinok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single case unions like "type U = C" are interpreted as ITypeAbbreviationRepresentation.
So this PR adds the needed code to add a
|in front and to fix the indentation.